Fix Linux CEF library discovery#974
Open
caniko wants to merge 1 commit into
Open
Conversation
Author
|
We might need to tune the logic, only tested on my own PC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On Linux, prepend Grayjay's bundled
cef/directory toLD_LIBRARY_PATHbefore starting the CEF process.Why
CEF's ANGLE backend loads EGL libraries with
dlopen()at runtime. The bundledlibEGL.sois next tojustcefnative, but that directory is not guaranteed to be present in the dynamic loader's search path. When it cannot resolve EGL, the CEF subprocess exits during startup and Grayjay remains on a blank/gray window.The path is added only on Linux, preserves the existing value, and is inherited by CEF's browser and GPU subprocesses.
Validation
dotnet restore Grayjay.Desktop.CEF/Grayjay.Desktop.CEF.csprojdotnet build Grayjay.Desktop.CEF/Grayjay.Desktop.CEF.csproj --no-restore -v:qThe build completed successfully with 0 errors. Existing compiler/analyzer warnings remain unchanged.