Skip to content

chore(#1828): assign CODEOWNERS wildcard to maintainers team - #1844

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/1828-codeowners-maintainers
Open

fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/1828-codeowners-maintainers

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Changes the root CODEOWNERS wildcard rule from @fullsend-ai/core to @fullsend-ai/maintainers.

Context

The maintainers team was created by fullsend-ai/org#18 (merged 2026-10-29). That PR replaced fullsend-ai/org#16, which was closed without merging. In peribolos.yaml the new team has maintain permission on agents, and CODEOWNERS needs at least write access to take effect, so that is enough.

Testing

  • scan-secrets passed on the changed file and on the staged index.
  • pre-commit could not fetch remote hook repos in the sandbox (TLS error). Instead, the hooks that apply to this file from pre-commit-hooks v6.0.0 (end-of-file, trailing-whitespace, detect-private-key, merge-conflict, mixed-line-ending, large-files) and the lint-release-cases local hook were run directly. All passed.
  • make lint (skillsaw) could not run because uvx is not installed. It does not cover CODEOWNERS.

Reviewer notes

  • I checked only the declarative org config, not the team's live access on GitHub. After merging, check that GitHub shows no owner errors on CODEOWNERS.
  • CODEOWNERS is a protected path, so a human must approve this PR.

🤖 Generated with Claude Code


Closes #1828

Post-script verification

  • Branch is not main/master (agent/1828-codeowners-maintainers)
  • Secret scan passed (gitleaks — ec1ed4607ff6df637d09e7258abb426732f7cac9..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Final PR description secret scan passed (gitleaks — no-git)

Replace @fullsend-ai/core with @fullsend-ai/maintainers on the root
CODEOWNERS wildcard rule. The maintainers team was created in
fullsend-ai/org#18 (merged), whose peribolos.yaml grants it maintain
permission on this repository, which is sufficient for CODEOWNERS
entries to take effect.

Note: pre-commit could not fetch remote hook repos (TLS error); the
applicable pre-commit-hooks v6.0.0 hooks and lint-release-cases were
run directly and passed, and gitleaks ran via scan-secrets. make lint
(skillsaw) could not run (uvx unavailable) and does not cover
CODEOWNERS. The team's live GitHub access was not verified via API.

Closes #1828

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Oct 30, 2026
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner October 30, 2026 09:54
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:56 AM UTC · Completed 10:01 AM UTC

Commit: afd072b · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.58

@rh-hemartin
rh-hemartin enabled auto-merge October 30, 2026 10:00
@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Oct 30, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Minimal one-line config change by a bot matching the linked issue scope, with low churn and no regressions offsetting the single protected path modification to yield low composite risk.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] CODEOWNERS:2 — This PR modifies the protected path CODEOWNERS, changing the root wildcard owner from @fullsend-ai/core to @fullsend-ai/maintainers. It links issue CODEOWNERS: change @fullsend-ai/core to @fullsend-ai/maintainers #1828, which authorizes exactly this change, and the description explains the rationale. Human approval is always required for protected-path changes, whatever the context. The reviewer could not check the new team's membership or its live repository access, because the org config is in another repository. A human reviewer should confirm that @fullsend-ai/maintainers exists and has write-or-higher access to this repository. After merge, they should also check that GitHub shows no owner errors on CODEOWNERS. Otherwise GitHub ignores the owner, and the wildcard rule has no effective owner.
    Remediation: Obtain human maintainer approval for this protected-path change.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread CODEOWNERS
@@ -1,2 +1,2 @@
# These users have approval access to all resources (wildcard)
* @fullsend-ai/core
* @fullsend-ai/maintainers

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] protected-path

This PR modifies the protected path CODEOWNERS (root wildcard owner changed from @fullsend-ai/core to @fullsend-ai/maintainers). It links issue #1828, which authorizes this change, and the description explains the rationale. Human approval is always required for protected-path changes regardless of context. Membership and live repository access of @fullsend-ai/maintainers could not be verified from this review environment (the org config is in another repository).

Suggested fix: Obtain human maintainer approval; confirm @fullsend-ai/maintainers has write-or-higher access to this repository and that GitHub shows no owner errors on CODEOWNERS after merge.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Oct 30, 2026

This branch was successfully deployed

1 active deployment
dev — afd072b3 Deployed Oct 30, 2026 by fullsend-ai-coder[bot] via behaviour #1456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Triggers review agent dispatch requires-manual-review Review requires human judgment risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CODEOWNERS: change @fullsend-ai/core to @fullsend-ai/maintainers

1 participant