Skip to content

chore(deps): bump fullsend to e9690f264 for built-in provider resolution - #1597

Merged
waynesun09 merged 1 commit into
mainfrom
chore-bump-fullsend-builtin-providers
Oct 2, 2026
Merged

waynesun09 merged 1 commit into
mainfrom
chore-bump-fullsend-builtin-providers

Conversation

@waynesun09

Copy link
Copy Markdown
Member

Summary

The behaviour tests build fullsend at the version go.mod pins. The pin is fullsend d8cbb9744 (2026-09-30), which predates fullsend-ai/fullsend#7995. That change resolves bare built-in provider names (vertex-ai, github-ro, ...) to the definitions and profiles built into the binary. #1596 switches the fleet harnesses to those bare names, and its behaviour run fails on the old pin: the triage scenario's run gets no Vertex or GitHub provider, because before #7995 only openai was built in.

This bumps the pin to fullsend main e9690f264. Relevant changes in the range (61 merges):

Changes

  • go.mod: github.com/fullsend-ai/fullsend v0.43.1-0.20260930180729-d8cbb97441de → v0.44.1-0.20261002204052-e9690f26438e.
  • go.sum: adds only the two fullsend lines, as the previous bump (chore(deps): bump fullsend to d8cbb9744 for the OpenShell 0.1.2 behaviour fix #1561) did. go mod tidy against the published module fails on fullsend's nested internal/mintcore module; the behaviour workflow replaces both modules with the pinned checkout.

Testing

  • go build ./..., make lint, make test: pass.
  • The behaviour run on this PR is the check that nothing else in this repository breaks against the newer fullsend.

Merge before #1596.

🤖 Generated with Claude Code

The behaviour tests build fullsend at the version go.mod pins, d8cbb9744
(2026-09-30). That predates fullsend-ai/fullsend#7995, which resolves
bare built-in provider names to the definitions and profiles in the
binary. Fleet harnesses that switch to bare names (#1596) fail behaviour
on the old pin: the triage run gets no Vertex or GitHub provider.

Bump the pin to fullsend main e9690f264, which includes #7995, #7976
(GitHub providers declare GH_TOKEN) and #7016 (GraphQL endpoint in the
built-in github-ro profile). go.sum gains only the two fullsend lines, as
in the previous bump; go mod tidy cannot resolve fullsend's nested
internal/mintcore module from the published module, and the behaviour
workflow replaces both with the pinned checkout.

Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
@waynesun09
waynesun09 requested a review from a team as a code owner October 2, 2026 21:38
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Bump fullsend for built-in provider resolution

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Pin fullsend to a version that resolves bare built-in provider names used by upcoming fleet
 harnesses.
• Add the matching module checksums so behaviour tests can build against the new pin.
High-Level Assessment

Bumping the existing pin is the direct way to make built-in provider resolution available to the behaviour tests. No repository-side implementation is needed; the behaviour run is the important compatibility check before merging the fleet harness change.

Files changed (2) +3 / -1

Other (2) +3 / -1
go.modPin fullsend to e9690f264 +1/-1

Pin fullsend to e9690f264

• Moves the fullsend requirement from d8cbb97441de to e9690f26438e, which includes resolution of bare built-in provider names needed by the upcoming fleet harnesses.

go.mod

go.sumAdd checksums for the new fullsend pin +2/-0

Add checksums for the new fullsend pin

• Adds the module and go.mod checksums for the newly required fullsend version. Existing version checksums remain in place.

go.sum

@qodo-code-review

qodo-code-review Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (1)

Grey Divider


Remediation recommended

1. The pull request title uses an area scope 📜 Skill insight § Compliance
Description
The title chore(deps): bump fullsend to e9690f264 for built-in provider resolution uses deps as
its scope despite the repository's stated preference for issue-number scopes. The dependency bump is
linked to #1596 in the PR description, but the title does not use an issue number as its scope.
Code

go.mod[5]

+require github.com/fullsend-ai/fullsend v0.44.1-0.20261002204052-e9690f26438e
Relevance

●●● Strong

Recent PR #1257 accepted the same ticket-scope preference and explicitly prioritized issue-number
scopes over area scopes.

PR-#1257

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
COMMITS.md states a preference for issue-number scopes when addressing a specific issue. The changed
dependency pin identifies the work covered by this PR, while its supplied title uses deps rather
than an issue number.

COMMITS.md[49-51]
go.mod[5-5]
Skill: code-implementation

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The dependency-bump PR title uses an area scope where the repository's ticket-scope convention calls for an issue number.

## Fix Focus Areas
- go.mod[5-5]

## Recommended Fix
Update the PR title to use the appropriate linked issue number as its scope; leave the dependency change unchanged.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 58 rules
✅ Skills: 4 invoked
  code-review
  code-implementation
  pr-review
  docs-review
✅ Cross-repo context — repo relationships
  Explored: repo: fullsend-ai/fullsend (branch: main, sha: e9690f26) — View relationship
Review mode: ⚖️ Balanced: Although the diff is only a dependency pin, it changes a runtime dependency with provider resolution and authentication/profile behavior, so a careful compatibility review is warranted.

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread go.mod
go 1.26.5

require github.com/fullsend-ai/fullsend v0.43.1-0.20260930180729-d8cbb97441de
require github.com/fullsend-ai/fullsend v0.44.1-0.20261002204052-e9690f26438e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. The pull request title uses an area scope 📜 Skill insight § Compliance

The title chore(deps): bump fullsend to e9690f264 for built-in provider resolution uses deps as
its scope despite the repository's stated preference for issue-number scopes. The dependency bump is
linked to #1596 in the PR description, but the title does not use an issue number as its scope.
Agent Prompt
## Issue description
The dependency-bump PR title uses an area scope where the repository's ticket-scope convention calls for an issue number.

## Fix Focus Areas
- go.mod[5-5]

## Recommended Fix
Update the PR title to use the appropriate linked issue number as its scope; leave the dependency change unchanged.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:40 PM UTC · Completed 9:49 PM UTC

Commit: f2c4885 · View workflow run →

Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $0.81

@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Tiny, non-source dependency bump (go.mod/go.sum only, 4 lines, no protected or security-sensitive paths, author not a bot or first-timer, recent and jointly-modified history with no reverts or hack/workaround commit sentiment) keeps most Tier 1/2 dimensions low, but the two-file dependency-change signal pushes the dependency dimension to its max, lifting the weighted composite (~1.6) just over the low threshold into moderate; no issue was linked so weights were redistributed 62/38 between Tier 1 and Tier 2.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 2, 2026
@waynesun09
waynesun09 merged commit 803ac07 into main Oct 2, 2026
72 checks passed
@waynesun09
waynesun09 deleted the chore-bump-fullsend-builtin-providers branch October 2, 2026 21:49

This branch was successfully deployed

1 active deployment
dev — f2c48856 Deployed Oct 2, 2026 by waynesun09 via behaviour #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant