chore(ask-dev): CHAOS-6577 bump acr pin to c4945bb8 - #89
Merged
Merged
Conversation
Pin f32774cf (acr main after #680). No vendored contract file changes against a618ca15; the pin moves because acr widened its served surface (evidence refs scoped by result_id, truncation/limitation sentences, a team's investment mix as its own fact, facts query version v16) and the contract rule is pin-before-proof. Regenerated through the sync script; check --source is green against a clean acr checkout parked on f32774cf. ask-dev makes no source_evidence call, so there is no result_id to send. Two tests pin that the new disclosure sentences render verbatim.
…t the pinned schema and panel
chrisgeo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins acr
c4945bb87534b1e2533657b0306be819c1ec38ab(main after #679, including #672 result_id-scoped evidence refs, #677/#678 disclosures, #680 team investment mix + query version v16). Contract rule: any acr widening => ask-dev pin bump before any live proof.TEST-EVIDENCE
Executed end to end (ci/run_checks.sh ci at 042246e): format, contracts, corpus, lint, typecheck, unit (1050 passed), build, e2e (24 passed).
Claim executed: no vendored contract file changed.
git diff a618ca15 c4945bb8 --over the ten vendored paths inscripts/sync-acr-contracts.mjs(four JSON Schemas and six examples) is empty. The acrcontracts/dir DID change over that range (OpenAPIresult_idquery param on source_evidence,mcp_*tool schemas, endpoint-profiles, projection-batch fixture) but none of those files are in ask-dev's vendored set; ask-dev talks only toPOST /api/v1/context-fabric/investigations(src/lib/acr/client.ts), which is unchanged. acr's Go wire structs gained no field (internal/contracts/v1/context_fabric_types.godiff = comment + a prefix constant;types.goadds ajson:"-"field).pnpm acr:contracts:generate --source <acr@c4945bb8>thencheck --sourcegreen (acr checkout clean, parked on c4945bb8). Onlymanifest.jsonsource_commitand the three generated-file source headers move.Consumers of facts/limitations are pass-through (file:line):
DeterministicAnswerView.tsx:371,434,438,456(limitations and claimed_facts handed to panels),LimitationsPanel.tsx:40-44(renders each limitation string as text),FactRowsPanel.tsx:99(fact.rows ?? [], scalar-only rows per the pinnedClaimedFactRow),CanonicalResultInspector.tsx:263-267,EvidenceReferences.tsx(renders ids/labels, never fetches). No code branches onquery_version(telemetry/outcome.ts:308copies it).Input-domain cells executed (all in unit tests):
theme_breakdownbreakdown table, no legacy day rows) validates against the pinned result schema and renders as its own panel with all five themes (FactRowsPanel.test.tsx, "team investment mix fact (acr #680)"). Control: the same result with a row that nests a table is refused, so the acceptance can fail.LimitationsPanel.test.tsx).result_idbecause it makes nosource_evidencecall (grep for source_evidence/evidence fetch in src, scripts, tests: none outside vendored contracts).RISK-NOTES
query_versionv16 are opaque to ask-dev; the new tests pin that they keep validating and rendering.