chore(contracts): CHAOS-5926 Sync the subject-identity refusal basis - #88
Merged
Merged
Conversation
Pin a618ca15. The refusal-basis vocabulary gains subject_identity_unconfirmed: a follow-up that resolved to a different subject than the answer it continues, refused for a caller that cannot be asked to choose. Exactly one member is added, at both places the field is carried (the result's own refusal_basis and completeness.refusal_basis), in the vendored schemas and the generated types. Regenerated through the sync script, the only author of these artifacts; check --source is green against a clean acr checkout parked on the squash. Three tests accompany it: the refusal validates as-is, an unrecognized basis still rejects so the enum stays closed, and an executed repro shows the same document rejected by the prior pin's own schemas. Reverting only the two schema copies turns the validating test and the enum-vocabulary test red. Without this bump an answer carrying the new basis fails closed here with acr_contract_violation and reads as a rig failure rather than a pin gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST-EVIDENCE
Bumps the acr contract pin to a618ca15, which adds
subject_identity_unconfirmedto the refusal-basis vocabulary. This repo strict-validates every served result against its vendored schemas, so an answer carrying the new basis would fail closed withacr_contract_violationuntil the pin moves.node scripts/sync-acr-contracts.mjs generate --allow-write --source <acr checkout at a618ca15>;check --sourcereports "ACR contracts are current". Vendored delta is exactly one enum member, at both places the field is carried (context_fabric_investigation_result.v1andcontext_fabric_common.v1AnswerCompleteness), plus the generated types and manifest digests.src/lib/acr/validate.test.ts: the refusal validates as-is; an unrecognized basis still rejects (the enum stays closed); an executed repro strips the member from everyrefusal_basisenum and shows the same document rejected, so the tests prove the bump is what made it acceptable. The existing vocabulary-size pin moves 6 → 7 and names the new member.pnpm format:check,eslint .,tsc --noEmit,pnpm buildrc0;vitest run62 files / 1045 tests pass, from a realpnpm install.RISK-NOTES
refusal_basisis a machine field the panels do not render; the refusal's own fixed sentence reaches the reader through the limitations list, as for the other refusal bases.