To provide wheels files for Windows, Linux, ...

[mantielero]

I am unable to install this package in Windows. It would be nice if binary installation packages were produced. Such as wheels files.

[fedelibre]

Perhaps PR #41 may solve this? I haven't tested it.
You can try:

pip install git+https://github.com/mitya57/python-poppler-qt5.git@sip5

[mantielero]

It is not working for me. I will post my issue in that thread.

Nonetheless, it would still be desirable to have a wheels for installation. There are many issues about the installation from those of us who are not that savvy.

[robin25]

Same for me, i'm not able to install on windows.

As I installed only PyQT5 on my system I haven't any qmake installed.

[fedelibre]

You should first run these commands:

pip install --upgrade pip
pip install --upgrade sip

then try installing python-poppler-qt5:

pip install git+https://github.com/mitya57/python-poppler-qt5.git@sip5

If you get an error, check #41 and report the problem if it's not been reported by others already.

[fedelibre]

@robin25 Sorry, I should not have pointed to that MR. It does not provide wheels for Windows, it just allows to build this module with sip v5 (instead of v4).

[robin25]

Hey @fedelibre anyway thank you for your help. I've tried but as you said it not provide wheels. I'm always looking for a workaround.

[Navi-Rajan]

@robin25 @mantielero Were you able to install it finally?

[fedelibre]

@robin25 After reading this comment I've just realized that now we can build python-poppler-qt5 using the sip-* commands (which read the pyproject.toml file).

Building a wheel for Linux seems as easy as running sip-wheel.
Here's the built file:

$ ls -l *.whl
-rw-r--r--. 1 fede fede 178726 Oct 12 23:27 python_poppler_qt5-21.1.0-cp310-cp310-manylinux2014_x86_64.whl

Perhaps running the same command on a Windows machine would allow to have a working wheel for Windows users? (to be uploaded on PyPI)

[fedelibre]

I tried using Github Actions and cibuildwheel to build wheels (initially for Linux, but can be done for Mac and Windows as well).

I'm using manylinux_2_24, the supported image based on Debian 9. If you compare it with the other manylinux images, it has the advantage of having Qt5 packages, but the big disadvantage of having a very old gcc compiler (6.3). In fact I think that the build is failing because of that, see this log:

https://github.com/fedelibre/python-poppler-qt5/runs/4015398642

There's an open issue in manylinux repository about upgrading GCC version in manylinux_2_24.

@mitya57 @bnavigator maybe you have some suggestions?

[mitya57]

Hi @fedelibre, and sorry for late response.

The problem is old Poppler version. You have Poppler 0.48, as can be seen in the log:

Get:114 http://security.debian.org/debian-security stretch/updates/main amd64 libpoppler-dev amd64 0.48.0-2+deb9u4 [774 kB]

But FormFieldText::setFontSize method was added in Poppler 0.60:
https://gitlab.freedesktop.org/poppler/poppler/-/commit/dfcf997e6fbca31d

You may wrap use of these new methods in %If(POPPLER_V0_60_0 -) … %End blocks, it should help.

It seems like no one else tested building with such an old version, so probably there will be other places where you will need to do the same.

[jeanas]

I'm looking into this, and I'm not quite sure how versioning is supposed to work for our wheels. See question: https://discuss.python.org/t/packaging-a-c-extension-with-a-dependency-on-another-c-extension/24462

[fedelibre]

@jeanas See my cibuildwheel branch. I managed to set up Github actions to build wheels for Linux and Mac. I had problems with Windows and eventually gave up.

[fedelibre]

Don't know if it answers your question, but if you download the artifact of this successful build you'll see the following names used by cibuildwheel:

[fede@fedora artifact]$ ls
python_poppler_qt5-21.3.0-cp310-cp310-macosx_10_13_x86_64.whl
python_poppler_qt5-21.3.0-cp310-cp310-manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl
python_poppler_qt5-21.3.0-cp311-cp311-macosx_10_13_x86_64.whl
python_poppler_qt5-21.3.0-cp311-cp311-manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl
python_poppler_qt5-21.3.0-cp37-cp37m-macosx_10_13_x86_64.whl
python_poppler_qt5-21.3.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl
python_poppler_qt5-21.3.0-cp38-cp38-macosx_10_13_x86_64.whl
python_poppler_qt5-21.3.0-cp38-cp38-manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl
python_poppler_qt5-21.3.0-cp39-cp39-macosx_10_13_x86_64.whl
python_poppler_qt5-21.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl

[jeanas]

Nice, I didn't know you had tried this in the past.

Those file names are precisely what my question is about. I don't see a place in those names for the PyQt5 version. It seems to me that using these wheels can only work if you install a specific PyQt5 version, but if they were uploaded on PyPI, pip-installing them would not work unless the PyQt5 version chosen by pip happened to be the same or ABI-compatible. We'd need to pin the PyQt5 version in pyproject.toml. This would work, but it's usually considered bad practice for a library to have pinned dependencies (because it creates dependency hells).

[jeanas]

(However, for Frescobaldi itself, it wouldn't be a problem.)