perf(evm): fold corpus mutation optimizations#15558
Draft
decofe wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 3, 2026
stevencartavia
approved these changes
Jul 3, 2026
0xKarl98
approved these changes
Jul 3, 2026
Member
|
I benchmarked the corpus changes against Results:
Recommendation: merge, but frame the cmp-sequence change as a memory/storage win rather than a CPU win. The single-argument mutation optimization is a clear targeted CPU improvement. The empty cmp-sequence path spends more CPU to detect and trim the all-empty payload, but avoids retaining/persisting thousands of empty cmp vectors, which is likely the more important behavior for corpus size and serialization overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the small corpus mutation perf PRs into one reviewable PR:
The folded changes are limited to corpus mutation bookkeeping:
Validation:
cargo fmt --allcargo test -p foundry-evm corpus --libPrompted by: @grandizzy