perf(invariant): reuse shrink replay sequence buffer#15320
Merged
Conversation
…euse-shrink-sequence # Conflicts: # crates/evm/evm/src/executors/invariant/shrink.rs
DaniPopes
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
DaniPopes
approved these changes
Jul 7, 2026
mablr
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse a single index buffer across invariant shrink-loop iterations instead of allocating a fresh
Vec<usize>per candidate viashrinker.current().collect().The shrink loops (
shrink_sequence,shrink_sequence_value,shrink_handler_sequence) run up toshrink_run_limit(default 5000) iterations, so this removes thousands of short-lived allocations per shrink by reusing one buffer (clear()+extend(), which retains capacity).Read-only
sequenceparams (check_sequence,check_sequence_value,replay_handler_failure_sequence,handler_sequence_still_triggers_bug) are changed fromVec<usize>to&[usize]. All consumers only borrowed the sequence (the innermostreplay_sequencealready takes&[usize]), so behavior is unchanged.