Skip to content

fix: update multistep labels reactively#1739

Open
justin-schroeder wants to merge 1 commit into
release/2.0.1from
fix/1377-multistep-label-i18n
Open

fix: update multistep labels reactively#1739
justin-schroeder wants to merge 1 commit into
release/2.0.1from
fix/1377-multistep-label-i18n

Conversation

@justin-schroeder
Copy link
Copy Markdown
Member

What changed

  • Updates multi-step stepName whenever a child step’s label prop changes, instead of copying the label only once when the step is registered.
  • Adds a regression that changes step labels after mount and verifies the tab label text updates, covering i18n/reactive label use cases.

Verification

  • pnpm exec vitest run --config /tmp/formkit-vitest-ci.mts packages/addons/__tests__/multistep.spec.ts -t "#1377" --reporter verbose
  • pnpm exec vitest run --config /tmp/formkit-vitest-ci.mts packages/addons/__tests__/multistep.spec.ts --reporter verbose
  • pnpm vitest --typecheck.only --run
  • node scripts/cli.mjs --script build addons reached successful CJS/ESM addon bundles, then failed during DTS on the existing @formkit/auto-animate package exports/type resolution issue in autoAnimatePlugin.ts.

Security

  • No new inputs, storage, network, or data exposure paths. This only keeps existing display text in sync with reactive label props.

Closes #1377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant