Skip to content

Update tabbable and focus-trap#1952

Merged
stefcameron merged 1 commit into
masterfrom
update-tabbable
Jun 22, 2026
Merged

Update tabbable and focus-trap#1952
stefcameron merged 1 commit into
masterfrom
update-tabbable

Conversation

@stefcameron

@stefcameron stefcameron commented Jun 22, 2026

Copy link
Copy Markdown
Member
PR Checklist

Please leave this checklist in your PR.

  • Issue being fixed is referenced.
  • Source changes maintain:
    • Stated browser compatibility.
    • Stated React compatibility.
  • Web APIs introduced have deep browser coverage, including Safari (often very late to adopt new APIs).
  • Unit test coverage added/updated.
  • E2E test coverage added/updated.
  • Prop-types added/updated.
  • Typings added/updated.
  • Changes do not break SSR:
    • Careful to test typeof document/window !== 'undefined' before using it in code that gets executed on load.
  • README updated (API changes, instructions, etc.).
  • Changes to dependencies explained.
  • Changeset added (run npm run changeset locally to add one, and follow the prompts).
    • EXCEPTION: A Changeset is not required if the change does not affect any of the source files that produce the package bundle. For example, demo changes, tooling changes, test updates, or a new dev-only dependency to run tests more efficiently should not have a Changeset since it will not affect package consumers.

Summary by CodeRabbit

  • Bug Fixes

    • Resolved a visibility issue in focus-trap functionality, ensuring proper element detection and keyboard navigation across different component states
  • New Features

    • Extended support for image area elements, improving accessibility and keyboard navigation for image-based interactive controls
  • Chores

    • Updated underlying dependencies to incorporate stability improvements and feature enhancements

@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 532f8aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
focus-trap-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5c386f-4dc5-4c26-8f64-9d0d4271c368

📥 Commits

Reviewing files that changed from the base of the PR and between b8ec7b8 and 532f8aa.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .changeset/five-dryers-sell.md
  • package.json

Walkthrough

Bumps focus-trap from ^8.2.1 to ^8.2.2 and tabbable from ^6.4.0 to ^6.5.0 in package.json. Adds a changeset file marking a patch release for focus-trap-react, noting the updates address a visibility bug fix and add image area support.

Changes

Dependency Version Bumps

Layer / File(s) Summary
Dependency bump and changeset entry
package.json, .changeset/five-dryers-sell.md
focus-trap bumped to ^8.2.2 and tabbable to ^6.5.0; changeset file added to document the patch release with notes on the visibility bug fix and image area support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes only the checklist template with no actual details about the changes, rationale, or why dependencies were updated. Critical sections like 'PR Details' and 'Changes to dependencies explained' are empty. Add a detailed description explaining why these dependencies were updated, what bugs/features they fix, and any potential impact on users before the checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—updating tabbable and focus-trap dependencies. It's concise and specific enough to understand the primary focus.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-tabbable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@stefcameron stefcameron merged commit 26c3dea into master Jun 22, 2026
3 checks passed
@stefcameron stefcameron deleted the update-tabbable branch June 22, 2026 01:42
@coderabbitai coderabbitai Bot mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant