Offload trigger inputs at registration#1176
Merged
pingsutw merged 20 commits intoJun 12, 2026
Merged
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
…nt-selectcluster-flow-to-offload
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
katrogan
commented
Jun 8, 2026
| "aiolimiter>=1.2.1", | ||
| "flyteidl2==2.0.20", | ||
| # LOCAL DEV: pinned to local gen/python via [tool.uv.sources] below. Restore "flyteidl2==2.0.20" before merge. | ||
| "flyteidl2", |
Contributor
Author
There was a problem hiding this comment.
will update to an official release version before merge
katrogan
commented
Jun 8, 2026
Contributor
Author
There was a problem hiding this comment.
I'll revert all these examples before merge
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
…nt-selectcluster-flow-to-offload
pingsutw
previously approved these changes
Jun 10, 2026
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
previously approved these changes
Jun 11, 2026
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
previously approved these changes
Jun 11, 2026
kumare3
reviewed
Jun 11, 2026
| await controller.finalize_parent_action(tctx.action) | ||
|
|
||
|
|
||
| def _inject_kickoff_time_from_run_start(inputs: Inputs, run_start_time: datetime) -> Inputs: |
Contributor
There was a problem hiding this comment.
can we not do it here and instead do it at -
you have it in the ctx already so you can just get it from the ctx internal_ctx or task context
kumare3
reviewed
Jun 11, 2026
|
|
||
| # Offloaded triggers carry the kickoff-time input arg name in inputs.context; fill that input | ||
| # from run_start_time (the scheduled fire time) before native conversion. No-op otherwise. | ||
| if inputs is not None and run_start_time is not None: |
Contributor
There was a problem hiding this comment.
remove this part, we dont need to reopen the inputs
kumare3
reviewed
Jun 11, 2026
| # on the trigger spec. At fire time the backend passes this straight through as the run's | ||
| # OffloadedInputData and stamps run_start_time, instead of inlining a kickoff literal. | ||
| # The task was just fetched above and is already registered, so we reference it by task_id. | ||
| offloaded_input_data = await trigger_serde.offload_trigger_inputs( |
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
…nt-selectcluster-flow-to-offload
…nt-selectcluster-flow-to-offload
pingsutw
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And read kickoff time input from the run context, using the newly added run_start_time from #1100
Depends on flyteorg/flyte#7482
Testing
[x] regular trigger (TaskTriggerSpec) Ran https://github.com/flyteorg/flyte-sdk/blob/main/examples/triggers/basic.py and verified output included valid kickoff time
[x] deployed trigger (TriggerSpec) Using
[x] cached trigger (TaskTriggerSpec) Using this script
And verified subsequent runs used cached output from the first run.
[x] run time always injected: Using this script
Verified individual runs output the kickoff time
ref eng26-533