add the rnote cli to the windows inno build#1758
Conversation
|
Not sure if it is possible with Inno, but I've seen installers asking whether they can add a path entry to |
|
Now this works with The only part that doesn't work is the build:
meson compile ui-cargo-build -C {{ build_folder }}
meson compile cli-cargo-build -C {{ build_folder }}and the second command doesn't exist if the cli = false option is selected. It errors with |
|
Seems like adding to path as an option is possible: see https://github.com/mentebinaria/retoolkit/blob/f86f5e608836b898da36a3787eb5135d2baef976/src/installer/retoolkit.iss#L214 |
This is so running with `-Dcli=false` works. - The meson configuration file checks whether the conditions are there (windows and build cli enabled) - If so, a `-DMyAppCliExeName=...` string is passed to the ìnno_build.py` file and passed with the iscc command as an argument - An if Defined statement is used in the iss file - Optional adding/removing from path the rnote-cli command
|
Updated to include the optional path update in the installer
Window release CI: https://github.com/Doublonmousse/rnote/actions/runs/25447031215 |
We pass the cli name from the meson build to the inno script only if we want to package it, and the script takes care of doing the define itself
|
Waiting for the window release CI to pass : https://github.com/Doublonmousse/rnote/actions/runs/29529431184 (and to double check we do get the cli.exe) |
|
looks good now 👍 Tested the artifact and confirmed the CLI is bundled and added to PATH on installation. |

CI test on : https://github.com/Doublonmousse/rnote/actions/runs/25228946601
Fixes #1757
TODO
-Dcli=false? I'm not sure whether it fails when failing to copy a file or how to adapt the script more cleanly for this)