feat: add floating terminal window option for flix commands#3
Open
Blackmorse wants to merge 1 commit into
Open
feat: add floating terminal window option for flix commands#3Blackmorse wants to merge 1 commit into
Blackmorse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My usual flow for running Flix commands is to pop them into a floating terminal, read the output, then close it — rather than keeping a persistent split around. Until now
flix_cmdalways opened abelowright splitwith no way to change that.This PR makes the terminal behavior configurable via a new
terminaloption, so the split can be replaced with a floating window.Changes
terminal.window—"split"(default, keeps the existingbelowright split) or"float"(opens a floating window).width/height— accept a fraction of the editor size (e.g.0.5) or an exact column/row count (integer).pos_x/pos_y— accept a number or"center".close_binding— Normal-mode key that closes the floating window (defaultq).Example