Use next's GPU metrics implementation for GPU_fdinfo class#2085
Open
17314642 wants to merge 6 commits into
Open
Use next's GPU metrics implementation for GPU_fdinfo class#208517314642 wants to merge 6 commits into
17314642 wants to merge 6 commits into
Conversation
Owner
and replace using GPU_fdinfo in amdgpu for proc_vram to FDInfo
… as part of legacy mangohud
17314642
force-pushed
the
gpu-fdinfo-use-next
branch
from
d2503f3 to
a26c1f5
Compare
Contributor
Author
|
Sure thing, done! |
Quote from cppreference: regex_match - attempts to match a regular expression to an ENTIRE character sequence regex_search - attempts to match a regular expression to ANY PART of a character sequence in this case we want partial matches instead of full matches if we want full match, we should specify it in regex expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every driver except for amdgpu and nvidia will now use gpu metrics from mangohud-next
I tested that it works on Intel ARC A770 using both 64-bit and 32-bit builds and mangoapp in gamescope.
proc_vram using fdinfo from mangohud-next for amdgpu also works
I implemented it using opaque pointer technique to not expose any headers from next to legacy and also making as little changes as possible to the mangohud-next's codebase.