Repository navigation
[BHP1-1660] Fix RoS and Flame Length Not being Enabled - #310
Merged
Merged
Conversation
…summary table being permanently set
This reverts commit 9bd5d41.
This reverts commit 3efe782.
The subs that decide which outputs appear in the results read the enabled outputs with a bare `d/q` on `@@s/conn`, which re-frame cannot see: a DataScript transaction does not touch `app-db`, and `[:worksheet ws-uuid]` is a `ReactiveEntity` that is `=` to its previous value on every recompute (it hashes on `:eid` alone), so its signal never propagates. Unticking an output therefore changed none of their inputs and the cached list was served stale, leaving a row for an output the last solve never computed until the page was reloaded. Introduce `:worksheet/enabled-output-uuids`, a re-posh `:query` sub, which does track the conn, and make it the signal for `:worksheet/output-uuids-conditionally-filtered`, `:worksheet/output-uuids-filtered`, `:worksheet/directional-parent-output-uuids`, `:worksheet/graphed-output-uuids` and `:worksheet/all-output-uuids`. Their remaining `d/q` only touches `@@vms-conn`, which is immutable at runtime. Ordering, the `hide-result?`/`hide-graph?` removal, the conditional evaluation and `(remove hidden?)` are unchanged. `:worksheet/all-output-uuids` matters beyond display: it is the output set the solver reads. Also stop a missing result cell from rendering as the string "NaN". `:worksheet/first-row-results-gv-uuid->value` returns nil when there is no cell, `(neg? nil)` is false in CLJS, so nil reached `continuous-fmt` and `js/parseFloat` printed "NaN". Guard the formatter, which covers the flat table, the matrices, the CSV export and the diagram summary table, and check for nil explicitly alongside the `neg?`/`pos?` tests in the matrices. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ut uuids""" Moved to kc-BHP1-1660-fix-non-reactive-output-enabling, which branches from b08a079 so this revert cannot undo it on a later merge. The non-reactive output subs and the "NaN" formatting are a separate concern from :output/implicit?. This reverts commit 8312c6898e6ba0cd0e8e4df6f3bb2c93adf63c93. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…1660-fix-non-reactive-output-enabling
Contributor
|
After re-downloading the latest VMS data from Dev, it worked. Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Closes BHP1-1660
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)