fix(cli): harden init MCP installer - #167
Merged
Merged
Conversation
hmishra2250
marked this pull request as ready for review
July 27, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawl initMCP setup through the pinned hosted installeradd-mcp/firecrawl-mcpsubprocess path and stored-key child environmentContract
https://mcp.firecrawl.dev/v2/mcpValidation
pnpm exec vitest run src/__tests__/commands/init.test.tspnpm test(389 passed, 1 skipped)pnpm run type-checkpnpm run format:checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Hardened
firecrawl initMCP setup and kept it usable without exposing keys. Interactive flow now delegates to the pinned hosted installer with a keyless fallback and redacted error messages.installMcp(pinned) withkeylesswhen no environment-backed key is present; no more skipped install.add-mcp/firecrawl-mcpsubprocess and the child env that carriedFIRECRAWL_API_KEY.Written for commit c28d8ed. Summary will update on new commits.