feat(auth): improve invalid password guidance for OAuth accounts#1379
feat(auth): improve invalid password guidance for OAuth accounts#1379kevinfernandes-hub wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the wrongPassword error message to a more descriptive text advising users to try their previous sign-in method if they used another provider. This change is applied to the English (US and GB) locale files, type definitions, and various test suites. The review feedback suggests refactoring the tests to reference the enUs translation object directly rather than hardcoding the long error message string, which will improve test maintainability.
Summary
Improves the error message shown when a user attempts Email + Password sign-in for an account that was originally created using another provider.
Previously, users would only see "Incorrect password", which could be confusing for accounts without a password.
This change replaces the message with:
Motivation
Addresses issue #1313 by providing more helpful guidance while preserving existing authentication behavior and avoiding email enumeration concerns.
Changes
Closes #1313.