simplification for async slides#396
Open
robamu wants to merge 2 commits into
Open
Conversation
Deploying ferrous-systems-rust-training with
|
| Latest commit: |
d6aa44f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e3b3f9f.ferrous-systems-rust-training.pages.dev |
| Branch Preview URL: | https://simplify-async-slides.ferrous-systems-rust-training.pages.dev |
| } | ||
| .await; | ||
| // By awaiting, we are actually executing the code asynchronously. | ||
| let read_from_disk_future = read_from_disk("Cargo.toml").await; |
Member
There was a problem hiding this comment.
Suggested change
| let read_from_disk_future = read_from_disk("Cargo.toml").await; | |
| let read_from_disk_future = read_from_disk(); | |
| let result = read_from_disk_future.await; |
Member
There was a problem hiding this comment.
I think we should keep this as two lines, so we can see that one makes the future, and one causes the future to run, blocking this function until the future has completed.
|
|
||
| ```rust [], ignore | ||
| fn main() { | ||
| // This code will not start reading from the disk by its own! |
Member
There was a problem hiding this comment.
Suggested change
| // This code will not start reading from the disk by its own! | |
| // This code will not start reading from the disk on its own! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.