Skip to content
This repository was archived by the owner on Dec 15, 2020. It is now read-only.
This repository was archived by the owner on Dec 15, 2020. It is now read-only.

Environment.setBackground gives an error #825

Description

@talwaserman

Description

Environment.setBackground gives an error
and this is what is instructed to be used in the docs located in this page
https://facebook.github.io/react-360/docs/photos-and-videos.html

Environment.setBackground( asset('path/to/image.jpg'), {format: '2D'}, /* one of the formats mentioned above */ );

Expected behavior

as i understand you should update the docs to instruct the following

Environment.setBackgroundImage( './static_assets/360_world.jpg', {format: '2D'} );

Actual behavior

gives an error

Reproduction

just following the docs.

Solution

as described, use the following:

Environment.setBackgroundImage( './static_assets/360_world.jpg', {format: '2D'} );

What needs to be done to address this issue? Ideally, provide a pull request with a fix.
please update your doc file in the following address, so others will not have the same issue, thanks
https://facebook.github.io/react-360/docs/photos-and-videos.html

Additional Information

  • 'react-360' package version: react-360@1.1.0
  • 'react-360-web' package version: react-360-web@1.1.0
  • Operating System: MacOS
  • Browser: Chrome

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions