Feature/api 4653 scope provider field - #1746
Draft
Samuelfaure wants to merge 9 commits into
Draft
Conversation
Samuelfaure
force-pushed
the
feature/api-4653-scope-provider-field
branch
from
August 28, 2026 08:27
4081ca9 to
8f9b76f
Compare
Samuelfaure
marked this pull request as ready for review
August 28, 2026 09:08
Samuelfaure
requested review from
Isalafont,
jbfeldis and
skelz0r
and removed request for
Isalafont and
jbfeldis
August 28, 2026 09:08
Contributor
|
Vu très en diagonale, je lirai pour de vrai mardi prochain, mais tu as vu qu'on avait déjà une "db" des providers dans |
Contributor
Author
|
J'ai raté ça je vais étudier ta solution 👍 |
Samuelfaure
marked this pull request as draft
August 28, 2026 10:10
Member
|
Pour moi c'est un sujet exclusivement API E/P qui n'a pas lieu d'exister sur DataPass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related datagouv/apistration#359
Problem: API Entreprise & Particulier have different scope formats, which is inconsistent and makes fetching of scopes more complex than it should be;
The "group" is used as a provider field abusively, it was not meant for that, better to register provider as an actual provider
Solution: align those & add more information to the config by use of a new provider field in YAML
Additional proposition: align all data providers in datapass with the same format (WDYT?)