Skip to content

Feature/api 4653 scope provider field - #1746

Draft
Samuelfaure wants to merge 9 commits into
developfrom
feature/api-4653-scope-provider-field
Draft

Feature/api 4653 scope provider field#1746
Samuelfaure wants to merge 9 commits into
developfrom
feature/api-4653-scope-provider-field

Conversation

@Samuelfaure

Copy link
Copy Markdown
Contributor

Related datagouv/apistration#359

Problem: API Entreprise & Particulier have different scope formats, which is inconsistent and makes fetching of scopes more complex than it should be;
The "group" is used as a provider field abusively, it was not meant for that, better to register provider as an actual provider

Solution: align those & add more information to the config by use of a new provider field in YAML

Additional proposition: align all data providers in datapass with the same format (WDYT?)

@linear

linear Bot commented Aug 28, 2026

Copy link
Copy Markdown

API-4653

@Samuelfaure
Samuelfaure force-pushed the feature/api-4653-scope-provider-field branch from 4081ca9 to 8f9b76f Compare August 28, 2026 08:27
@Samuelfaure
Samuelfaure marked this pull request as ready for review August 28, 2026 09:08
@Samuelfaure
Samuelfaure requested review from Isalafont, jbfeldis and skelz0r and removed request for Isalafont and jbfeldis August 28, 2026 09:08
@jbfeldis

Copy link
Copy Markdown
Contributor

Vu très en diagonale, je lirai pour de vrai mardi prochain, mais tu as vu qu'on avait déjà une "db" des providers dans service_providers.yml, ça serait cool d'utiliser ça pour récupérer le label non ? (et du coup relier via leur id et non le label)

@Samuelfaure

Copy link
Copy Markdown
Contributor Author

J'ai raté ça je vais étudier ta solution 👍

@Samuelfaure
Samuelfaure marked this pull request as draft August 28, 2026 10:10
@skelz0r

skelz0r commented Aug 30, 2026

Copy link
Copy Markdown
Member

Pour moi c'est un sujet exclusivement API E/P qui n'a pas lieu d'exister sur DataPass.
En réalité faut juste simplifier coté API E/P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants