Skip to content

fix: restore ordinary points to white, tint only the high-score highlight - #33

Merged
ericboehs merged 1 commit into
masterfrom
fix/dark-mode-highscore-only
Aug 30, 2026
Merged

fix: restore ordinary points to white, tint only the high-score highlight#33
ericboehs merged 1 commit into
masterfrom
fix/dark-mode-highscore-only

Conversation

@ericboehs

Copy link
Copy Markdown
Owner

Tinting every point flattened the distinction light mode draws between an ordinary score and one above the next threshold. Dropping the blanket .points rule lets ordinary points fall back to exactly what they rendered before any of this.

Verified in the browser per scheme:

story title ordinary points high-score points
dark rgb(255,255,255) rgb(255,255,255) rgb(88,166,255)
light rgb(13,13,13) rgb(13,13,13) rgb(30,135,240)

Dark mode now mirrors light mode's structure rather than inventing its own: ordinary points match the titles, and only the high-score highlight is tinted.

The explicit visited rule goes too. It was only needed because the blanket rule outranked the global table a:visited; without it the original cascade applies unchanged, so clicked stories dim to grey exactly as before.

Rejected one review finding

A reviewer flagged the comment as inaccurate, claiming ordinary points render UIkit's default link blue #1e87f0 rather than white, since they're anchors.

That's contradicted by both the stylesheet and the browser. UIkit 3.3.3's .uk-light rule targets anchors explicitly:

.uk-light .uk-link, .uk-light a, ... { color: #fff }

and the measured computed style for an unvisited ordinary point is rgb(255,255,255). The comment stands as written.

Tests: 119 runs, 320 assertions.

…ight

Tinting every point flattened the distinction light mode draws between an
ordinary score and one above the next threshold. Dropping the blanket
.points rule lets ordinary points fall back to exactly what they rendered
before any of this: UIkit's .uk-light white, and grey once visited via the
global `table a:visited`.

The explicit visited rule goes with it. It was only needed because the
blanket rule outranked that global one; without it the original cascade
applies unchanged.

Dark mode now mirrors light mode's structure rather than inventing its
own. Verified in the browser -- dark: ordinary points rgb(255,255,255)
matching the titles, high-score rgb(88,166,255). Light: unchanged at
rgb(13,13,13) and rgb(30,135,240).
@ericboehs
ericboehs merged commit 7c54695 into master Aug 30, 2026
2 checks passed
@ericboehs
ericboehs deleted the fix/dark-mode-highscore-only branch August 30, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant