fix: restore ordinary points to white, tint only the high-score highlight - #33
Merged
Conversation
…ight Tinting every point flattened the distinction light mode draws between an ordinary score and one above the next threshold. Dropping the blanket .points rule lets ordinary points fall back to exactly what they rendered before any of this: UIkit's .uk-light white, and grey once visited via the global `table a:visited`. The explicit visited rule goes with it. It was only needed because the blanket rule outranked that global one; without it the original cascade applies unchanged. Dark mode now mirrors light mode's structure rather than inventing its own. Verified in the browser -- dark: ordinary points rgb(255,255,255) matching the titles, high-score rgb(88,166,255). Light: unchanged at rgb(13,13,13) and rgb(30,135,240).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tinting every point flattened the distinction light mode draws between an ordinary score and one above the next threshold. Dropping the blanket
.pointsrule lets ordinary points fall back to exactly what they rendered before any of this.Verified in the browser per scheme:
rgb(255,255,255)rgb(255,255,255)rgb(88,166,255)rgb(13,13,13)rgb(13,13,13)rgb(30,135,240)Dark mode now mirrors light mode's structure rather than inventing its own: ordinary points match the titles, and only the high-score highlight is tinted.
The explicit visited rule goes too. It was only needed because the blanket rule outranked the global
table a:visited; without it the original cascade applies unchanged, so clicked stories dim to grey exactly as before.Rejected one review finding
A reviewer flagged the comment as inaccurate, claiming ordinary points render UIkit's default link blue
#1e87f0rather than white, since they're anchors.That's contradicted by both the stylesheet and the browser. UIkit 3.3.3's
.uk-lightrule targets anchors explicitly:and the measured computed style for an unvisited ordinary point is
rgb(255,255,255). The comment stands as written.Tests: 119 runs, 320 assertions.