fix: tint only the points in dark mode, not the story titles - #32
Merged
Conversation
Story titles go back to UIkit's .uk-light white; the blue is now confined to the points column, which is what was actually wanted. Also fixes a claim in the previous PR. It said the story detail page title was fixed, but views/story.erb never made it into the commit -- a `git checkout views/story.erb` while probing ETag behaviour reverted the uncommitted change first. The file was absent from the merge. That page should keep white titles now anyway, so nothing needs adding back. Visited points keep the grey they already had: the new rules are more specific than `table a:visited`, so without an explicit rule they would have started overriding it and clicked stories would stop dimming. Verified in the browser per scheme. Dark: title rgb(255,255,255), points rgb(88,166,255). Light: unchanged at rgb(13,13,13) with the high-score highlight still rgb(30,135,240). One consequence worth naming: light mode distinguishes ordinary points from high-scoring ones by colour, and tinting every point blue flattens that distinction in dark mode.
Visited listing titles are grey, not white -- the global `table a:visited` outranks UIkit. And the visited rule preserves grey *points* in dark mode, where the new scoped selectors would otherwise outrank that global rule; light mode was never affected.
ericboehs
force-pushed
the
fix/dark-mode-points-only
branch
from
August 30, 2026 03:35
20d24b3 to
9984414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story titles go back to UIkit's
.uk-lightwhite. The blue is now confined to the points column.Verified in the browser per scheme:
rgb(255,255,255)rgb(88,166,255)rgb(88,166,255)rgb(0,0,0)rgb(13,13,13)rgb(13,13,13)rgb(30,135,240)rgb(255,255,255)Light mode is untouched.
A correction to PR #31
That PR's description claimed the story detail page title was fixed to blue. It wasn't —
views/story.erbnever made it into the commit. Agit checkout views/story.erbwhile probing ETag behaviour reverted the uncommitted change first, and the file is absent from the merge (git log -Sconfirms the class never landed on any branch).The claim was wrong and I should have checked the diff rather than trusting the edit. That page should keep white titles now anyway, so nothing needs adding back.
Visited links
The new
.pointsselectors are more specific than the globaltable a:visited, so without an explicit rule clicked stories would have stopped dimming — in dark mode only. An explicit visited rule preserves the existing grey.One consequence worth naming
Light mode distinguishes ordinary points (
#0d0d0d) from high-scoring ones (#1e87f0) by colour. Tinting every point blue flattens that distinction in dark mode — both are now#58a6ff. If you want the highlight back, ordinary points can take a dimmer blue.Tests: 119 runs, 320 assertions.