fix(msp): preserve nacos dependency for mse clusters#6786
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f670aa3d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| handlers.MseNacosPort: "8848", | ||
| }) | ||
|
|
||
| if _, ok := info.Dice.AddOns[handlers.ResourceNacos]; !ok { |
There was a problem hiding this comment.
Avoid deploying Nacos child add-ons on MSE
When an MSE cluster has MS_NACOS_* and config-center/registercenter needs a new Nacos tenant, preserving the raw nacos add-on sends the recursive deploy through the normal Nacos handler. The coordinator resolves that handler's dice add-ons before checking CheckIfHasCustomConfig (coordinator.go:123-180), and the Nacos handler is wired to consume MySQL subresource output (nacos.go:60-65), so the first tenant path can create an unused MySQL dependency/tenant before switching to the external MSE Nacos. The same expectation is mirrored in the registercenter test; please strip Nacos child add-ons for the MSE custom path or otherwise keep tenant creation without deploying Nacos's internal dependencies.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6786 +/- ##
==========================================
+ Coverage 15.82% 15.84% +0.01%
==========================================
Files 3998 3998
Lines 328179 328165 -14
==========================================
+ Hits 51933 51983 +50
+ Misses 270350 270281 -69
- Partials 5896 5901 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2f670aa to
4c3ea49
Compare
4c3ea49 to
117a892
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?