Replace progress_bar with custom utility function#461
Open
JustAman62 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
progress_bardependency and replaces its single usage with a small utility function which renders a somewhat similar progress bar when downloading models.Example output snippet (terminal was sized to 50cols to make this easy to read):
I've tried to implement just enough for this download use case and not much more, except for making sure the method doesn't failover on weird inputs, and supports non-byte unit progress.
This is my first contribution to this lib so please do let me know if I've forgotten to do something, or am not matching the code style in any way :)
Relates to #458.