Gemma4 model implementation#460
Draft
edenamram wants to merge 7 commits into
Draft
Conversation
…eTensor for large tensor support
edenamram
force-pushed
the
gemma4-model-implementation
branch
from
73aa3c2 to
0d707a6
Compare
…rs and enhance attention block implementation
| } | ||
|
|
||
| outputs = | ||
| Enum.reduce(0..(spec.num_blocks - 1), initial_state, fn idx, state -> |
Member
There was a problem hiding this comment.
We generally use Layers.Transformer.blocks as much as possible, to avoid duplicating all that code, which is harder to maintain. When models introduce something novel, we add options to that function as needed to accommodate for the change. Ideally it's something we would do here as well.
Member
|
Hey, thanks for the PR! The most important part is to ensure the implementation is correct. The contributing section describes how to add tests with reference values generated using Python hf/transformers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.