feat(extension): dispatch unknown top-level commands to installed extensions#303
Open
margaretjgu wants to merge 4 commits into
Open
feat(extension): dispatch unknown top-level commands to installed extensions#303margaretjgu wants to merge 4 commits into
margaretjgu wants to merge 4 commits into
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts MegaLinter is graciously provided by OX Security |
449c3a8 to
3773081
Compare
16c6dc0 to
85f9a76
Compare
3773081 to
9958a96
Compare
85f9a76 to
9e829f6
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #297. Part of #222. Depends on #302.
src/extension/runner.tswithrunExtension(ext, args, contextEnv): spawns the extension entrypoint withshell: false, merges context env vars into the inherited environment, and resolves with the child's exit codecli.ts: after all built-in commands are registered, checks whetherfirstArgmatches any of the known built-in command names; if not, looks up the extension registry and execs the extension, forwarding remaining argv and the resolved context env varsSecurity:
spawnis called withshell: falseand an explicit args array. The entrypoint path is validated bystore.tsto be an absolute path within the install directory before it is ever written to the registry.Test plan
npx tsc --noEmitpasses cleanelastic some-unknown-cmdstill errors normally when no extension is installedelastic localdispatches toelastic-localbinary afterelastic extension install github:elastic/elastic-local(functional)ELASTIC_ES_URLandELASTIC_ES_API_KEYin its environment