DYNINST_REWRITER_NO_UNLINK=1 causes testsuite failures

[kupsch]

If the environment variable DYNINST_REWRITER_NO_UNLINK is set and the entire testsuite is run several tests fail, due to the instrumented libc.so being reused.

[hainest]

I'm seeing proccontrol failures in current HEAD of master (44b6564) when the rewritten binaries/libtestA.so is present.

$ unset DYNINST_REWRITER_NO_UNLINK
$ export DYNINST_DEBUG_PROCCONTROL=1

$ ./test_driver -all -v -debugPrint -log snip_change_shlib_var.log -test snip_change_shlib_var >snip_change_shlib_var.pc.log 2>&1

TEST                       COMP   OPT  ABI MODE     THREAD  LINK    PIC     RESULT
snip_change_shlib_var      g++    none 64  create   NA      dynamic nonPIC  PASSED
snip_change_shlib_var      g++    none 64  attach   NA      dynamic nonPIC  FAILED (Running Test)

[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f9f9e4a5000
[sysv.C:280-U] - Creating new library object for /home/tim/paradyn/build/testsuite/tests/libtestA.so
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f9f9e4a5000
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f9f9e4a5000
[sysv.C:277-U] - Found library ./binaries/libtestA.so at 7fe386ad1000
[sysv.C:280-U] - Creating new library object for ./binaries/libtestA.so
[sysv.C:277-U] - Found library ./binaries/libtestA.so at 7fe386ad1000
[sysv.C:305-U] - Didn't find old library ./binaries/libtestA.so at 7fe386ad1000, unloading

------------------------------

$ rm binaries/libtestA.so

$ ./test_driver -all -v -debugPrint -log snip_change_shlib_var.log -test snip_change_shlib_var >snip_change_shlib_var.pc.log 2>&1

TEST                       COMP   OPT  ABI MODE     THREAD  LINK    PIC     RESULT
snip_change_shlib_var      g++    none 64  create   NA      dynamic nonPIC  PASSED
snip_change_shlib_var      g++    none 64  attach   NA      dynamic nonPIC  PASSED

[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f2e21d5c000
[sysv.C:280-U] - Creating new library object for /home/tim/paradyn/build/testsuite/tests/libtestA.so
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f2e21d5c000
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f2e21d5c000
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f6867a57000
[sysv.C:280-U] - Creating new library object for /home/tim/paradyn/build/testsuite/tests/libtestA.so
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f6867a57000
[sysv.C:277-U] - Found library /home/tim/paradyn/build/testsuite/tests/libtestA.so at 7f6867a57000