Chore/434 parent title interface#37
Open
sbrody wants to merge 3 commits into
Open
Conversation
To allow the underlying logic of how parent titles are generated to be adjusted a ParentTitleGetter interface is created. A new class called MUltPageParentClass implements the interface with the current default logic. It can now be injected into the ParentTitle class, as can other approaches
Also update tests for ParentTitle and MultiPageParentTitle, which takes existing functionality and moves it into its own class
sbrody
force-pushed
the
chore/434-parent-title-interface
branch
from
a3261cb to
8d05f38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
To allow the underlying logic of how parent titles are generated to be adjusted a ParentTitleGetter interface is created.
A new class called MultPageParentClass implements the interface with the current default logic. It can now be injected into the ParentTitle class, as can other approaches
...
Checklist