Skip to content

fix(ci): gate the release notes backfill behind reviewer approval #37142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfreudenthaler wants to merge 1 commit into from
+16 −0
Open

fix(ci): gate the release notes backfill behind reviewer approval #37142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/cicd_ai-release-notes-backfill.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,24 @@ concurrency:
cancel-in-progress: true

jobs:
# The phase's final step is `gh release edit --notes-file`, an unconditional replace on a
# public release body — it overwrites hand edits and cannot be undone from here.
# workflow_dispatch is open to every account with write access on this repo, so reviewer
# approval is the access control. Same pattern as cicd_evergreen-tracks-promote.yml.
# The environment must carry required_reviewers; GitHub auto-creates it UNPROTECTED on
# first use if it is missing, which would silently remove this gate.
gate:
name: Approve Notes Rewrite
runs-on: ubuntu-${{ vars.UBUNTU_RUNNER_VERSION || '24.04' }}
environment: release-notes-backfill
steps:
- run: |
echo "Approved: rewrite release notes for ${{ inputs.release_tag }}"
echo "Previous tag: ${{ inputs.previous_tag || '(auto-detect)' }}"

release-notes:
name: Generate Notes
needs: gate
uses: ./.github/workflows/cicd_comp_ai-release-notes-phase.yml
with:
release_tag: ${{ inputs.release_tag }}
Expand Down
Loading