Fix Model::__get() swallowing \Throwable - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the broad try { ... } catch (\Throwable) { return; } wrapper around the entire method body.
The previous implementation was silently swallowing all exceptions, including genuine application errors from cast resolution, relation queries, computed properties, and other property-resolution logic.
It was also masking dead code: the explicit throw new \Exception("Property or relation '$name' does not exist...") could never reach the caller because it was immediately caught by the enclosing catch. The "not found" case has therefore been simplified to a direct return null;, while all other exceptions are now allowed to propagate normally.