Fix #9 after_created hook ordering - #308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Updated the insert path in
InteractsWithModelQueryProcessing.phpso that the model's primary key is assigned beforefireAfterHooks('created')is executed, rather than three lines afterward.As a result,
after_createdhooks now receive a fully initialized model, and calls such asgetKey()or$model->idcorrectly return the newly created record's primary key instead ofnull.Tests
Extended
MockHookto capture the result ofgetKey()from inside the hook callback.Strengthened
testAfterCreatedHookto verify that:createdhook is notnull.The regression test was verified by temporarily reverting the fix and confirming that the test fails with:
Failed asserting that null is not nullThe test was then re-run with the fix in place and passes successfully.