Fix #4 done: path traversal in Storage - #306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The
LocalFileSystem,PublicFileSystem, and sharedFileSystemimplementations were constructing filesystem paths using naive string concatenation:$this->filePath . '/' . $pathThis was done across methods such as
get(),content(),delete(),destinationFile(), andisDirectoryExists(). The implementation did not reject path traversal sequences such as..or verify that the resolved path remained within the intended filesystem root, creating a potential path traversal vulnerability.Fix
The filesystem path handling has been updated to ensure that:
..are rejected.Additional Finding
During the review, I also identified a third, previously unreviewed class:
PublicFileSystem.php. It contained the same vulnerable path-handling pattern through the sharedFileSystembase class, including the sameget(),content(), anddelete()behavior.This was fixed as part of the same change to avoid leaving an obvious sibling implementation vulnerable.