fix: SQL identifier injection - #302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three security fixes for the ORM/query layer, found during a framework-wide review:
Authenticate::setUser()now regenerates the session ID on every login path (fresh login, 2FA completion, remember-cookie resume) before writing the auth key.save()-as-update andupdate()previously skipped the$creatablewhitelist filter entirely when a model didn't declare$creatable(only insert enforced it). Both paths now require$creatableto be declared, matching insert's existing guarantee.where(),orderBy(),groupBy(),whereIn(),whereBetween(),whereNull(),whereLike(), and thewhereDate/whereMonth/whereYear/whereDay/whereTimehelpers interpolated column names (andorderBy's direction) into SQL with no validation — only values were bound. Added a strict identifier allowlist (columnortable.column) validated at each entry point, across both query builder classes (Entity\BuilderandEntity\Query\Builder).whereRaw()/orderByRaw()/groupByRaw()remain the unchanged, intentional raw-SQL escape hatch.