Give NamedQuery template its own JsonProperty Order - #1286
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
donaldgray
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
NamedQuery.GlobalandNamedQuery.Templateboth declared[JsonProperty(Order = 11)], so their relative order in serialised responses was contractually undefined — the observed wire order (name,global,template) held only because Json.NET happens to stable-sort equal Orders by declaration order.This moves
templateto Order 12, making the observed order the contractual one. The emitted JSON is byte-identical to today's output — no behavioural change, just removing the dependence on an implementation-detail coincidence.Same defect class as #1235 (duplicate Orders on ImageStorage/ApiKey/PortalUser); this instance was spotted during that PR but deliberately left as it wasn't on that change's ratified list.
Non-breaking. NamedQuery tests pass (13/13).
🤖 Generated with Claude Code