Priority queue response gets its own @id - #1277
Merged
Merged
Conversation
GET /customers/{c}/queue/priority returned a body whose @id was
/customers/{c}/queue - the main queue's identity - making the two
resources distinguishable only by their counts. The converter now
appends the queue name to the @id for any non-default named queue.
The collection links (batches/active/recent/priority) deliberately
remain those of the main queue: batches submitted to the priority
queue appear in those shared collections, and no per-name sub-routes
exist. Integration tests assert both halves.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
donaldgray
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
GET /customers/{customerId}/queue/priorityreturns the priority queue's own counts, but its@idwas/customers/{customerId}/queue— the main queue's identity — and all its collection links were the main queue's links. Two different resources returned bodies distinguishable only by their counts, and the priority response contained aprioritylink pointing back at itself under the main queue's URL space. Cause:CustomerQueueConverter.ToHydrahad no queue-name awareness, so the model's UriTemplate always stamped the main-queue identity.This PR makes the converter append the queue name to the
@idfor any non-default named queue, so the priority response now self-identifies as/customers/{customerId}/queue/priority.The collection links (
batches,active,recent,priority) deliberately remain the main queue's URLs: batches submitted to the priority queue genuinely appear in those shared collections (the documentation already explains this), and no per-name sub-routes (/priority/batchesetc.) exist — auto-generating links off the new@idwould have produced four dead links. Integration tests assert both halves: the priority@id, the sharedbatcheslink, and the unchanged default-queue identity.Breaking Changes
Caution
This PR introduces breaking changes.
/customers/{customerId}/queue/priorityresponse@idchanges from.../queueto.../queue/priority@idwill see the new value