Remove the never-populated estCompletion property from Batch - #1273
Merged
Conversation
Batch.EstCompletion has never been set by anything - BatchConverter.ToHydra does not populate it and no other code references it - so it has never appeared in a wire response (null-suppressed). It was however declared in the Hydra vocab and, since the OpenAPI schema mapping landed, visible in Swagger as a real-looking response property. Remove the phantom; if a batch-completion estimate is ever wanted it can be designed as a fresh feature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
donaldgray
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the
estCompletionproperty from theBatchHydra model.Batch.EstCompletion("Estimated Completion (best guess as to when this batch might be finished)") has never been populated:BatchConverter.ToHydradoes not set it, and no other code in the solution references it at all — nothing computes it and nothing reads it. Because it is always null it has never appeared in an actual wire response, so nothing can be depending on it. It is not mentioned in any issue or RFC, and the documentation site does not document it.Until now the only visible trace was the vocab entry, but since #1268 the property also appears in the OpenAPI schema as a real-looking read-only response property, which makes the phantom actively misleading to API consumers reading the Swagger docs.
This removal is vocab/schema-only — no wire response changes (the property was never emitted). If a batch-completion estimate is wanted in future it can be designed as a fresh feature.