refactor: Toml11 4.4 - #2568
Merged
Merged
Conversation
This includes updating toml11 to 4.4 and using the nixpkgs supplied onedpl
trisyoungs
approved these changes
Aug 6, 2026
Comment on lines
+35
to
+38
| bool Geometry::operator==(const Geometry &rhs) const | ||
| { | ||
| return value_ == rhs.value_ && std::equal(std::begin(indices_), std::end(indices_), std::begin(rhs.indices_)); | ||
| } |
Member
There was a problem hiding this comment.
Excellent. Been meaning to fix this particular warning for a while!
|
|
||
| struct wo_comment_config | ||
| { | ||
| using comment_type = toml::discard_comments; // XXX |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #2560
This PR upgrades our toml11 dependency from 3.7.0 to 4.4.0. This allows us to switch to cmake version 4. I also upgrade to the latest nixpkgs release (we were over a year out of date). Additionally, I have fixed us on GCC 14 on Linux, since GCC 15 has a known bug with compiling Qt at this time.