Use ghcr address as registry ref in docker build cache-to#728
Use ghcr address as registry ref in docker build cache-to#728AdrianDAlessandro wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a504bf7 to
be26e44
Compare
|
@sbland We need to get this PR merged before we can deploy any new releases. So if you want your new features live, I'll need an approving review. I'm not confident enough of my understanding of docker manifests, etc to merge this without a second opinion |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions Docker build/publish pipeline to avoid overwriting published GHCR image manifests with BuildKit cache artifacts (the root cause described in #723). It does this by moving the BuildKit registry cache to a dedicated :buildcache tag and pinning the published image platform to linux/amd64 for Azure compatibility.
Changes:
- Write BuildKit
cache-totoghcr.io/<owner>/<repo>:buildcacheinstead of using the application image tag(s). - Add
cache-fromto read from both GHA cache and the dedicated GHCR:buildcachetag. - Set
platforms: linux/amd64for the docker/build-push-action invocation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish.yml | Renames the publish step label to reflect that it publishes (no behavior change). |
| .github/actions/docker-build/action.yml | Moves registry cache to a dedicated :buildcache tag and pins build platform to linux/amd64 to prevent manifest corruption and improve deploy compatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
be26e44 to
331a79c
Compare
Description
This PR implements the suggested fix by @davehorsfall to fix the bug with deployed images not working. I think this is what you meant, Dave...
Fixes #723
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks