Restart to install screen when last app is uninstalled#3777
Draft
avazirna wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When uninstalling an app from the App Manager, CommCare always restarted to
AppManagerActivity. If the uninstalled app was the last installed app, that left the user on an empty app-manager screen.This change picks the restart target based on whether any installed app records remain after uninstall:
DispatchActivity(routes to the install/setup screen)AppManagerActivity(unchanged behavior)Notes
MultipleAppsUtil.appRecordArray(), read afterAppLifecycleUtils.uninstall(...), which removes theApplicationRecordfrom global storage before returning on success.uninstall(...)aborts mid-way (e.g. a file/db can't be deleted), the record remains in storage, so the count stays>= 1and we safely route toAppManagerActivity.Note
Base is
fix-flaky-instrumentation-tests(stacked PR) — this branch was split off from it. Rebase ontomasteronce the base branch merges.🤖 Generated with Claude Code