Skip to content

chore: update pre-commit version#42

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
stevenhua0320:pre-commit-update
May 29, 2026
Merged

chore: update pre-commit version#42
sbillinge merged 1 commit into
diffpy:mainfrom
stevenhua0320:pre-commit-update

Conversation

@stevenhua0320
Copy link
Copy Markdown
Contributor

@sbillinge ready to review. In this PR, I updated the pre-commit version to the latest one and also I noticed that there is a conflicting behavior in the imageplot.py to the address to str object. Since that str is in the built-in one, I changed to the Str from traits so that the linter could correctly identify the format and tackle it properly while there is no functionality affected.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.00%. Comparing base (d674e17) to head (4e65177).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
tests/conftest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files           2        2           
  Lines          18       18           
=======================================
  Hits            9        9           
  Misses          9        9           
Files with missing lines Coverage Δ
tests/conftest.py 35.71% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevenhua0320
Copy link
Copy Markdown
Contributor Author

Even though codecov fails here, I checked and it is because newer version black changes the formatting of the code, so we are safe to merge this.

@sbillinge sbillinge merged commit 1286026 into diffpy:main May 29, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants