Read Receipts#136
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adds first-class support for DirectChat delivery/read receipts (“Read Receipts”) across parsing, GeoJSON conversion, type schemas, and builders.
Changes:
- Extend the CoT
Detailschema to recognize__chatreceipt. - Populate
properties.chatfrom__chatreceiptwhen converting CoT → GeoJSON. - Add
CoT.is_chat_receipt()helper,DirectChatReceiptbuilder, and receipt-focused tests (ATAK + WinTAK styles).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/chat.test.ts | Adds parsing and builder tests for chat receipt CoTs. |
| lib/types/types.ts | Extends Detail schema to include optional __chatreceipt. |
| lib/parser/to_geojson.ts | Maps __chatreceipt detail into properties.chat for GeoJSON output. |
| lib/cot.ts | Introduces is_chat_receipt() helper for receipt detection. |
| lib/builders/chat.ts | Adds DirectChatReceipt builder and receipt status/type mapping. |
| CHANGELOG.md | Documents new chat receipt parsing, helper, builder, and tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.