Complete vpad functions and some docs fixes.#446
Open
dkosmari wants to merge 3 commits into
Open
Conversation
added 3 commits
May 6, 2026 23:11
- Added `const` to `pattern` parameter in `VPADControlMotor()` - Docs: moved note about single gamepad into `VPADChan` enum. - Docs: removed redundant link/endlink commands. - Docs: fixed some docs.
Contributor
|
Could you also add a comment specifying the VPAD accelerometer unit? And |
Comment on lines
+1041
to
+1051
| int32_t | ||
| VPADWriteTPCalibrationValueToEEPROM(VPADChan chan, | ||
| uint32_t unknown1, | ||
| uint32_t unknown2, | ||
| uint32_t unknown3, | ||
| uint32_t unknown4, | ||
| uint32_t unknown5, | ||
| uint32_t unknown6, | ||
| uint32_t unknown7, | ||
| uint32_t unknown8, | ||
| uint32_t unknown9); |
Contributor
There was a problem hiding this comment.
There seems to be one too many unknown parameters.
I assume these map to the touchpad calibration in the Gamepad EEPROM, although there is some confusing scaling done by VPAD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VPADChanenum.VPADGetButtonProcModechanged its return type to an enum.