Add detected changes to new template to preserve source template Resource dict integrity. - #1
Open
kyleian wants to merge 1 commit into
Open
Add detected changes to new template to preserve source template Resource dict integrity.#1kyleian wants to merge 1 commit into
kyleian wants to merge 1 commit into
Conversation
…urce dict integrity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed when running the macro on a subset of some of my ECS Services that occasionally ServiceWaitCondition would never receive a paramHash update. After testing and adding some logs I realized it was never getting evaluated while looping over the Resources after the ServiceWaitHandle gets a hash.
This change allows for the new hashed handler/condition resources to not get added back to the original dict we're looking at so that the ServiceWaitCondition resource doesn't get occasionally skipped.