client: don't time out long logins, report login progress#3618
Open
peterzen wants to merge 1 commit into
Open
Conversation
The first login after startup connects wallets and DEX servers synchronously in the /api/login handler, which can outlast the HTTP server's 2-minute WriteTimeout. When that happened, login completed server-side but the response carrying the auth cookie was cut off, leaving the user stuck on the unlock screen until a hard refresh. Clear the write deadline for the login response so it always arrives. Also report finer-grained login progress through the existing LoginNote pipe: per-item completion counts for wallets and DEX servers, plus a periodic note naming the wallets or servers a slow login is still waiting on, so the unlock screen shows what is actually happening. If the websocket drops while the login request is pending, the login form now flags the displayed status as possibly stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the long-standing stuck-unlock-screen issue (#3031): the first login after startup connects wallets and DEX servers synchronously in the login handler, which could outlast the HTTP server's 2-minute write timeout — login completed server-side but the auth cookie never reached the browser, leaving the user stuck until a hard refresh.