dbeaver/pro#8796 [CB] create a separate plugin for the execution plan#4406
Open
SychevAndrey wants to merge 5 commits into
Open
dbeaver/pro#8796 [CB] create a separate plugin for the execution plan#4406SychevAndrey wants to merge 5 commits into
SychevAndrey wants to merge 5 commits into
Conversation
Move all Execution Plan logic out of plugin-sql-editor into a new plugin-sql-editor-execution-plan. plugin-sql-editor no longer knows about execution plan and instead exposes generic extension points Execution plan tab data now lives in-memory in SqlExecutionPlanService instead of the persisted editor state schema (these tabs are session-only).
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 82 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
devnaumov
reviewed
Jun 18, 2026
| override register(): void { | ||
| this.sqlResultTabsService.resultPanels.add(SqlExecutionPlanPanel, 0, ({ tabId }) => !this.sqlExecutionPlanService.has(tabId)); | ||
|
|
||
| this.sqlResultTabsService.onResultTabClose.addHandler(({ state, tabId }) => { |
Member
There was a problem hiding this comment.
its better to add handlers on the constructor level
|
|
||
| export type ISqlEditorResultTab = schema.infer<typeof SQL_EDITOR_RESULT_TAB_SCHEMA>; | ||
|
|
||
| export const EXECUTION_PLAN_TAB_SCHEMA = schema.object({ |
Member
There was a problem hiding this comment.
could you clarify how handleTabRestore is working now in terms of executionPlanTabs
Contributor
Author
There was a problem hiding this comment.
Before we used to restore tabs and then clear the state. That's why handleTabRestore looks weird. But now it happens on it's own because we keep tabs only in the in-memory Map. Anyways, result is the same: tabs don't restore after reload
devnaumov
previously approved these changes
Jun 18, 2026
sergeyteleshev
previously approved these changes
Jun 22, 2026
SychevAndrey
dismissed stale reviews from sergeyteleshev and devnaumov
via
0816aa3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added a linter rule for interface names