Release/0.1.3 - #85
Open
khalilmalla95 wants to merge 9 commits into
Open
Conversation
The maven-full job downloads only target/ directories from maven-quick, so linter-core is not available in the local Maven repository when javadoc:javadoc runs for linter-cli. Install the pre-built JAR with install:install-file before the matrix steps so inter-module dependencies resolve without hitting Maven Central. Also replace an unescaped '&' in FhirAuthorizationCache Javadoc to silence invalid-input warnings during Javadoc generation.
…or API v2 SpringConfigurationLinter only inspected @bean return types, which matches API v1 but misses API v2 plugins that register BPMN activities through ActivityPrototypeBeanCreator. That produced false PLUGIN_DEFINITION_SPRING_CONFIGURATION_MISSING errors (e.g. on dsf-process-ping-pong API v2). Extract activity Class literals from static ActivityPrototypeBeanCreator @bean methods and treat them as prototype-covered. Split lint types and messages by API version so v1 (@bean) and v2 (APBC / prototype activity) findings are not mixed: add PLUGIN_DEFINITION_ACTIVITY_PROTOTYPE_BEAN_MISSING and SPRING_ACTIVITY_PROTOTYPE_BEAN_CREATOR. Extend unit tests for v1/v2 positive and negative cases.
For API V2 plugins, SpringConfigurationLinter now distinguishes how a BPMN-referenced activity is registered in the plugin's @configuration classes. Only registration exclusively via ActivityPrototypeBeanCreator (APBC) is reported as SUCCESS. Any @Bean-based registration triggers a WARN, because V2 plugins are expected to register activities through APBC rather than individual @bean factory methods. Behavior (API V2 only; V1 and UNKNOWN unchanged): - Activity in APBC only -> SUCCESS (SPRING_ACTIVITY_PROTOTYPE_BEAN_CREATOR) - Activity in APBC and as @bean -> WARN (SPRING_ACTIVITY_REGISTERED_TWICE) - Activity as @bean only (not in APBC) -> WARN (SPRING_ACTIVITY_REGISTERED_AS_BEAN) - Activity in neither APBC nor @bean -> ERROR (PLUGIN_DEFINITION_ACTIVITY_PROTOTYPE_BEAN_MISSING, unchanged) Implementation details: - Step 5.5 now computes inApbc and inBean per BPMN reference using the existing APBC extraction and configProvidesClass() bean coverage check. - Added providedByBean() helper to reuse the same bean-type matching logic across all registered @configuration classes. - V2 dual/@Bean-only cases skip the APBC SUCCESS item and the existing @Scope/mutability pass, since the registration style itself is the issue. - Overall coverage summary (SUCCESS) is still emitted when all references are covered, even if some are WARN-level registration-style findings. New LintingType values: - SPRING_ACTIVITY_REGISTERED_TWICE - SPRING_ACTIVITY_REGISTERED_AS_BEAN Tests: - v2Covered_viaApbcAndBean_reportsRegisteredTwiceWarn - v2Covered_viaBeanOnly_reportsRegisteredAsBeanWarn - Existing APBC-only V2 success and V1 @Bean/scope tests remain unchanged
…iguration-linter-falsely-reports-missing-bean-for-api-v2-plugins-that-use-activityprototypebeancreator fix: recognize ActivityPrototypeBeanCreator in Spring config checks f…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #71 #69 #67 #65 #63 #56 #54 #48 #41 #40 #39 #38 #37 #36
v0.1.3 adds JSON-based issue exclusions, Spring bean validation for BPMN references, a required process-level message start event, improved FHIR/Task checks, and HTML reports with embedded source navigation. Several false positives and severity levels were fixed, plus Maven Central and CI updates.