fix: preserve negative zero in std.round#1044
Open
He-Pin wants to merge 1 commit into
Open
Conversation
fe61a64 to
75c6cb9
Compare
He-Pin
commented
Jun 26, 2026
9d702ba to
a146eca
Compare
Collaborator
|
please fix PR. |
a146eca to
ab773d4
Compare
ab773d4 to
3de1b5c
Compare
Contributor
Author
|
@stephenamar-db fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
std.round(-0)returned positive zero in sjsonnet, while go-jsonnet and jrsonnet preserve the negative zero sign. This matters for programs that observe signed zero through functions such asstd.atan2.Modification
std.roundreceives either+0or-0.Result
std.round(-0)-0-00-0std.round(0)0000std.atan2(std.round(-0), -1)now observes the negative-zero sign.Risks
std.round(-0)case.