DAOS-19449 dfuse: fix EOF logic to avoid corruption (#18824) - #18859
Open
mjmac wants to merge 1 commit into
Open
DAOS-19449 dfuse: fix EOF logic to avoid corruption (#18824)#18859mjmac wants to merge 1 commit into
mjmac wants to merge 1 commit into
Conversation
The drain path for reads that raced the pre-read set the EOF flag without updating the read position, so a later read there got an empty reply: zero-filled files, or SIGBUS from mmap. Writes also left the flag armed, returning stale EOF over appended data. The flag is now set only next to the position update, and the early-EOF reply checks doh_linear_read first. Adds two new ftests that trigger the problems when run without the fixes. Signed-off-by: Michael MacDonald <github@macdonald.cx>
|
Ticket title is ' dfuse pre-read returns stale EOF' |
mjmac
added
waiting-for-merge-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drain path for reads that raced the pre-read set the EOF flag
without updating the read position, so a later read there got an
empty reply: zero-filled files, or SIGBUS from mmap. Writes also
left the flag armed, returning stale EOF over appended data. The
flag is now set only next to the position update, and the early-EOF
reply checks doh_linear_read first.
Adds two new ftests that trigger the problems when run without
the fixes.
Signed-off-by: Michael MacDonald github@macdonald.cx