DAOS-16311 test: adapt daos_cr.c to libdaos_control bindings - #18849
Draft
mjmac wants to merge 1 commit into
Draft
DAOS-16311 test: adapt daos_cr.c to libdaos_control bindings#18849mjmac wants to merge 1 commit into
mjmac wants to merge 1 commit into
Conversation
Update the cat_recov suite to work better with the new libdaos_control bindings, which operate more quickly and correctly than the old fork/exec dmg wrappers. - Check repair takes the CIA_ action value directly, where the old dmg CLI translated a selection index into the action. - The bindings answer queries in milliseconds where the fork/exec dmg helpers took 1-2s, which throws off some of the timing assumptions in the tests. Adjust to use a wall-clock budget instead of counting query iterations. - Pool-not-found now maps to DER_NONEXIST instead of DER_MISC, so cr_cleanup no longer needs to tolerate DER_MISC. - Switch SystemCheckDisable() to use Force: true on SystemStop(), matching the current system default and avoiding hangs on shutdown. - Misc correctness fixes in the gRPC handlers for SystemCheck(Enable|Disable). Skip-hw-medium-ucx-provider: false Features: cat_recov daos_core_test_nvme Signed-off-by: Michael MacDonald <github@macdonald.cx>
|
Ticket title is 'C bindings for DAOS control API' |
Collaborator
|
Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18849/1/execution/node/1754/log |
Collaborator
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18849/1/execution/node/1701/log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the cat_recov suite to work better with the new
libdaos_control bindings, which operate more quickly and
correctly than the old fork/exec dmg wrappers.
dmg CLI translated a selection index into the action.
helpers took 1-2s, which throws off some of the timing assumptions
in the tests. Adjust to use a wall-clock budget instead of counting
query iterations.
cr_cleanup no longer needs to tolerate DER_MISC.
matching the current system default and avoiding hangs on shutdown.
SystemCheck(Enable|Disable).
Skip-hw-medium-ucx-provider: false
Features: cat_recov daos_core_test_nvme
Signed-off-by: Michael MacDonald github@macdonald.cx