Skip to content

Rename npm build script to compile - #8

Merged
AndreasArvidsson merged 2 commits into
mainfrom
files
Aug 1, 2026
Merged

Rename npm build script to compile#8
AndreasArvidsson merged 2 commits into
mainfrom
files

Conversation

@AndreasArvidsson

Copy link
Copy Markdown
Member

In pre commit 4.6 installing a git hook triggers the default build script. Doing that clears our dist folder and pre commit fails. Renaming build to compile fixes this regression.

@AndreasArvidsson
AndreasArvidsson merged commit 087a3ec into main Aug 1, 2026
1 check passed
@AndreasArvidsson
AndreasArvidsson deleted the files branch August 1, 2026 16:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6119d92066

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"dist/**/*.js",
"dist/**/*.d.ts",
"!dist/test/**",
"dist",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the specific dist file allowlist

When .github/workflows/deploy.yaml publishes this package, the broader dist entry includes all five generated .js.map files, reversing the immediately preceding “More specific files list” change. I verified with npm pack --dry-run --json that this increases the packed artifact from 17,712 to 75,679 bytes and the unpacked size from 68,977 to 300,311 bytes. Keep the dist/**/*.js and dist/**/*.d.ts allowlist so every release does not ship these unintended source maps.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant