Rename npm build script to compile - #8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6119d92066
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dist/**/*.js", | ||
| "dist/**/*.d.ts", | ||
| "!dist/test/**", | ||
| "dist", |
There was a problem hiding this comment.
Restore the specific dist file allowlist
When .github/workflows/deploy.yaml publishes this package, the broader dist entry includes all five generated .js.map files, reversing the immediately preceding “More specific files list” change. I verified with npm pack --dry-run --json that this increases the packed artifact from 17,712 to 75,679 bytes and the unpacked size from 68,977 to 300,311 bytes. Keep the dist/**/*.js and dist/**/*.d.ts allowlist so every release does not ship these unintended source maps.
Useful? React with 👍 / 👎.
In pre commit 4.6 installing a git hook triggers the default
buildscript. Doing that clears ourdistfolder and pre commit fails. Renamingbuildtocompilefixes this regression.